actually make CSRDataset and CSCDataset usable#1891
Closed
flying-sheep wants to merge 3 commits into
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1891 +/- ##
==========================================
- Coverage 86.10% 83.66% -2.44%
==========================================
Files 40 40
Lines 6238 6240 +2
==========================================
- Hits 5371 5221 -150
- Misses 867 1019 +152
🚀 New features to boost your workflow:
|
ilan-gold
reviewed
Mar 6, 2025
Comment on lines
+642
to
+643
| abc.CSRDataset.register(_CSRDataset) | ||
| abc.CSCDataset.register(_CSCDataset) |
Contributor
There was a problem hiding this comment.
This is a deep cut for me - don't these both already inherit from the ABC? I'd like to understand this one. Does it have to do with the multiple inheritance?
from anndata._core.sparse_dataset import _CSRDataset
from anndata.abc import CSRDataset
assert issubclass(_CSRDataset, CSRDataset)
Member
Author
There was a problem hiding this comment.
huh, you’re right.
I must have run into something else then, no idea why I thought that check wasn’t already right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oops, that should have been there from the start!